Skip to content

Add Windows installer #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 12, 2024
Merged

Add Windows installer #150

merged 14 commits into from
May 12, 2024

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented May 11, 2024 •
edited
Loading

TODO list:

  • check if we need to include a vcredist, yes we need to do that

CI build failures are related to gcc-14 silent upgrades and other things, that will be resolved in #149

@github-actions GitHub Actions
Copy link

github-actions bot commented May 11, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                                  Stmts    Miss  Cover    Missing
--------------------------------------  -------  ------  -------  --------------------------------------
src/game/mino.cpp                            10      10  0.00%    3-20
src/game/mino.hpp                             1       1  0.00%    19
src/game/mino_stack.cpp                      61      61  0.00%    7-91
src/graphics/point.hpp                        3       3  0.00%    16-23
src/helper/color.cpp                         85      35  58.82%   11-31, 38-53, 61, 75, 145-156, 161-164
src/helper/color.hpp                         83      65  21.69%   41, 45, 48, 73-101, 140-221
src/helper/color_literals.hpp               335      33  90.15%   51, 437, 592, 657-705, 719-722
src/helper/date.cpp                          46      46  0.00%    9-113
src/helper/errors.cpp                        16      16  0.00%    3-29
src/helper/errors.hpp                         0       0  100.00%
src/helper/parse_json.cpp                    23      23  0.00%    6-55
src/helper/random.cpp                        13      13  0.00%    4-24
src/helper/sleep.cpp                         15      15  0.00%    20-71
src/helper/utils.hpp                          2       2  0.00%    61-62
src/thirdparty/hash-library/sha256.cpp      417     417  0.00%    40-604
TOTAL                                      1110     740  33.33%

Results for commit: d03bfa7

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

@Totto16 Totto16 force-pushed the windows-installer branch 2 times, most recently from 2fa8127 to fe037fd Compare May 11, 2024 19:17
@Totto16 Totto16 force-pushed the windows-installer branch from fe037fd to 6e62fda Compare May 11, 2024 20:19
Totto16 added 6 commits May 11, 2024 23:20
@Totto16
windows installer: also install needed discord dll
e5cfe66
@Totto16
windows installer:
2a025bb 
- use bigger icon
- also set the unistaller icon
@Totto16
windows installer: improve many things
ab6c56e 
- add start menu entry
- remove optional desktop shortcut
 - correctly track optional installed features
 - use registry keys better
 - don't make the app hidden
@Totto16
windows installer:
871ce23 
- also install settings to correct location, don't override old ones
- refactor the directoyr finding in installer builds
@Totto16
settings: add additoonal setting to enable / disable discord integrat…
d8b0149 
…ions, it is disabled by default and by the by the default settings file
@Totto16
windows installer:
1e292ed 
-  add a seperate not required componenent, to install music files
- add information for windows intor the registry, so tha the uninstall feature of windows works as intended
@Totto16 Totto16 added the enhancement New feature or request label May 12, 2024
@Totto16 Totto16 added this to the 0.6.0 milestone May 12, 2024
@Totto16 Totto16 force-pushed the windows-installer branch from 83d3888 to 95b6258 Compare May 12, 2024 22:04
@Totto16
windows installer:
d03bfa7 
- also install the c++ Redist. Runtime Libraries
@Totto16 Totto16 force-pushed the windows-installer branch from 95b6258 to d03bfa7 Compare May 12, 2024 22:05
@Totto16 Totto16 merged commit 0464843 into feat/0.6.0 May 12, 2024
13 of 17 checks passed
@Totto16 Totto16 deleted the windows-installer branch May 12, 2024 22:20
This was referenced May 16, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.6
Development

Successfully merging this pull request may close these issues.
1 participant
@Totto16